This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
EVEREST-496 Add target namespaces to backup storages #415
Merged
recharte
merged 12 commits into
EVEREST-495-multi-namespaces
from
EVEREST-496-multi-namespaces-backup-storage
Feb 6, 2024
Merged
EVEREST-496 Add target namespaces to backup storages #415
recharte
merged 12 commits into
EVEREST-495-multi-namespaces
from
EVEREST-496-multi-namespaces-backup-storage
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recharte
force-pushed
the
EVEREST-496-multi-namespaces-backup-storage
branch
2 times, most recently
from
January 31, 2024 15:26
de260d5
to
ba52b36
Compare
recharte
force-pushed
the
EVEREST-496-multi-namespaces-backup-storage
branch
from
January 31, 2024 16:13
ba52b36
to
59fee69
Compare
ghost
reviewed
Feb 2, 2024
oksana-grishchenko
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approving since there is nothing to add from my side to the Michal's review.
ghost
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add target namespaces to backup storages
NOTE FOR REVIEWERS: Still missing api-tests, there are other dependencies (e.g. monitoring part) that need to be sorted out. I'll submit a follow-up PR to address the integration tests once the dependencies are sorted out.
Problem:
EVEREST-496
As per the everest-operator BackupStorage spec, they should have the target namespaces field that dictates in which namespaces it's allowed to be used.
CHECKLIST
Jira
Tests